feat(output): add configurable time_format with locale encoding fix#385
Merged
Conversation
Owner
|
Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
ui.output.time_formatconfig option to allow users to customize timestamp display format in message headers. Also fixes a locale encoding issue on Chinese Windows whereos.date('%b')returns GBK-encoded characters (e.g.5月→ displayed as5<d4><c2>).Changes
lua/opencode/config.luatime_format = nildefault underui.outputlua/opencode/types.lua---@field time_format string|niltoOpencodeUIOutputConfiglua/opencode/util.luatime_formatis set, uses it directly viaos.date(time_format, timestamp)os.date('%X', ...)andos.date('%b', ...)calls inos.setlocale('C', 'time')/restore pairs to prevent non-UTF-8 outputtests/unit/util_spec.luaUsage
When unset (nil), behavior matches the original format but with the encoding bug fixed.